Data types by jonnathan-ls · Pull Request #243 · javascript-tutorial/pt.javascript.info

jonnathan-ls · 2022-06-16T01:34:49Z

Data types

📝 Goal

Article update

☑ What was done?

Pending text translation

javascript-translate-bot · 2022-06-16T01:34:52Z

Error: the article already translated in the Progress Issue #1 ⁉️

jonnathan-ls · 2022-06-16T01:36:13Z

Error: the article already translated in the Progress Issue #1 ⁉️
#243 (comment) javascript-translate-bot

There is still text that has not been translated.

odsantos · 2022-12-09T22:48:39Z

Error: the article already translated in the Progress Issue #1 interrobang
#243 (comment) javascript-translate-bot

There is still text that has not been translated.

Hi,

Will you translate the missing parts, including solution and task?
It would be helpful to review that as lesson, the whole translated article as well as the rest.

Trying to know your plan regarding to this lesson.

Thanks, Osvaldo.

renatocfrancisco

In line 73, the english sentence still in the file.
Moreover, good job!

…t.info into fix/steps-types

jonnathan-ls · 2023-08-06T20:53:54Z

Olá @renatocfrancisco,

Obrigado pela observação, não tinha percebido ❤️

Olá @odsantos,

Will you translate the missing parts, including solution and task?
It would be helpful to review that as lesson, the whole translated article as well as the rest.

O PR contempla toda tradução do artigo, com exceção da linha 73 como citado pelo Renato
Adicionei um novo commit com o ajuste.

Por desencargo, também atualizei com a master do repositório original.

Poderia adicionar sua revisão a este PR?

odsantos · 2023-08-08T21:37:04Z

Hi @jonnathan-ls , sim. Logo que possivel. Obrigado.

nazarepiedady · 2024-04-02T05:26:50Z

@peruibeloko, @jonnathan-ls, what is missing in this pull request?

jonnathan-ls · 2024-04-07T19:25:41Z

... what is missing in this pull request?

The review by two maintainers is missing, I will not contribute with the review, as the PR is precisely my own, there is no point in reviewing it myself

@nazarepiedady Could you add your review?

nazarepiedady

We could improve it more ahead, but for now, it is good enough to be approved.

1-js/02-first-steps/05-types/article.md

nazarepiedady · 2024-04-07T19:42:56Z

@jonnathan-ls, now we need one more review. It should take some time because we are running under forces.

nazarepiedady · 2024-04-08T03:22:22Z

@peruibeloko, are you available to review this pull request?

peruibeloko

Duas mudanças rápidas e está aprovado

peruibeloko · 2024-04-08T15:43:47Z

1-js/02-first-steps/05-types/article.md

This section is duplicated at line 75

peruibeloko · 2024-04-08T15:47:23Z

1-js/02-first-steps/05-types/article.md

Você pode verificar a [tabela de compatibilidade do *MDN* sobre BigInt]

ou

Você pode verificar a [tabela de compatibilidade do BigInt na *MDN*]

javascript-translate-bot · 2024-04-08T15:47:55Z

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

nazarepiedady · 2024-04-09T11:00:46Z

@jonnathan-ls, could you consider the reviews did?

…vascript.info into pr/243

…fo) and apply translation See: https://github.com/javascript-tutorial/en.javascript.info/blob/master/1-js/02-first-steps/05-types/article.md#bigint-bigint-type

jonnathan-ls · 2024-04-14T17:39:13Z

... could you consider the reviews did?

/done @nazarepiedady

I applied the requests noted by @peruibeloko, see commit 4a7029e. And I also added pending content that I noticed when accessing the article from the official English repository bigint-type session, see commit 7cafcbb

nazarepiedady

It seems good enough to be approved.

peruibeloko

LGTM

javascript-translate-bot · 2024-04-16T07:17:16Z

Error: the article already translated in the Progress Issue #1 ⁉️

javascript-translate-bot added the review needed label Jun 16, 2022

javascript-translate-bot requested a review from a team June 16, 2022 01:34

fix(first-steps): translates the rest of the article about data types

f579000

jonnathan-ls force-pushed the fix/steps-types branch from b27374e to f579000 Compare June 16, 2022 01:35

renatocfrancisco reviewed Jul 31, 2023

View reviewed changes

Merge branch 'master' of https://github.com/jonnathan-ls/pt.javascrip…

31b5581

…t.info into fix/steps-types

refactor: corrects spelling errors and untranslated text

60e4ab4

jonnathan-ls mentioned this pull request Aug 6, 2023

Portuguese Translation Progress #1

Open

nazarepiedady approved these changes Apr 7, 2024

View reviewed changes

1-js/02-first-steps/05-types/article.md Outdated Show resolved Hide resolved

javascript-translate-bot added needs +1 and removed review needed labels Apr 7, 2024

peruibeloko suggested changes Apr 8, 2024

View reviewed changes

javascript-translate-bot added the changes requested label Apr 8, 2024

jonnathan-ls added 3 commits April 14, 2024 14:05

Merge branch 'master' of https://github.com/javascript-tutorial/pt.ja…

ed8e1b4

…vascript.info into pr/243

refactor: adds adjustments according to code review suggestions

4a7029e

feat: adds original content from English repository (en.javascript.in…

7cafcbb

…fo) and apply translation See: https://github.com/javascript-tutorial/en.javascript.info/blob/master/1-js/02-first-steps/05-types/article.md#bigint-bigint-type

javascript-translate-bot added review needed and removed changes requested labels Apr 14, 2024

javascript-translate-bot requested a review from a team April 14, 2024 17:39

nazarepiedady approved these changes Apr 14, 2024

View reviewed changes

peruibeloko approved these changes Apr 15, 2024

View reviewed changes

nazarepiedady merged commit e9d2d8c into javascript-tutorial:master Apr 16, 2024

jonnathan-ls removed needs +1 review needed labels Apr 28, 2024

Uh oh!

Conversation

jonnathan-ls commented Jun 16, 2022

Data types

📝 Goal

☑ What was done?

Uh oh!

javascript-translate-bot commented Jun 16, 2022

Uh oh!

jonnathan-ls commented Jun 16, 2022

Uh oh!

odsantos commented Dec 9, 2022

Uh oh!

renatocfrancisco left a comment

Choose a reason for hiding this comment

Uh oh!

jonnathan-ls commented Aug 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

odsantos commented Aug 8, 2023

Uh oh!

nazarepiedady commented Apr 2, 2024

Uh oh!

jonnathan-ls commented Apr 7, 2024

Uh oh!

nazarepiedady left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nazarepiedady commented Apr 7, 2024

Uh oh!

nazarepiedady commented Apr 8, 2024

Uh oh!

peruibeloko left a comment

Choose a reason for hiding this comment

Uh oh!

peruibeloko Apr 8, 2024

Choose a reason for hiding this comment

Uh oh!

jonnathan-ls Apr 14, 2024

Choose a reason for hiding this comment

Uh oh!

peruibeloko Apr 8, 2024

Choose a reason for hiding this comment

Uh oh!

jonnathan-ls Apr 14, 2024

Choose a reason for hiding this comment

Uh oh!

javascript-translate-bot commented Apr 8, 2024

Uh oh!

nazarepiedady commented Apr 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jonnathan-ls commented Apr 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nazarepiedady left a comment

Choose a reason for hiding this comment

Uh oh!

peruibeloko left a comment

Choose a reason for hiding this comment

Uh oh!

javascript-translate-bot commented Apr 16, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Comments

jonnathan-ls commented Aug 6, 2023 •

edited

Loading

nazarepiedady commented Apr 9, 2024 •

edited

Loading

jonnathan-ls commented Apr 14, 2024 •

edited

Loading